From 43fe431cce107bd311a68dea59ac0f672ac13615 Mon Sep 17 00:00:00 2001 From: David Craven Date: Tue, 14 Feb 2017 16:28:31 +0100 Subject: vm: Remove hard coded kernel file name. * gnu/system/vm.scm (system-qemu-image/shared-store-script, expression->derivation-in-linux-vm): Use operating-system-kernel-file and system-linux-image-file-name. * gnu/system.scm (system-linux-image-file-name): Add ARM. --- gnu/system/vm.scm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'gnu/system/vm.scm') diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm index 8a35f7fbc..a7203d169 100644 --- a/gnu/system/vm.scm +++ b/gnu/system/vm.scm @@ -141,7 +141,8 @@ made available under the /xchg CIFS share." (gnu build vm)) (let ((inputs '#$(list qemu coreutils)) - (linux (string-append #$linux "/bzImage")) + (linux (string-append #$linux "/" + #$(system-linux-image-file-name))) (initrd (string-append #$initrd "/initrd")) (loader #$loader) (graphs '#$(match references-graphs @@ -487,7 +488,7 @@ exec " #$qemu "/bin/" #$(qemu-command (%current-system)) #$@(if full-boot? #~() - #~(" -kernel " #$(operating-system-kernel os) "/bzImage \ + #~(" -kernel " #$(operating-system-kernel-file os) " \ -initrd " #$os-drv "/initrd \ -append \"" #$(if graphic? "" "console=ttyS0 ") "--system=" #$os-drv " --load=" #$os-drv "/boot --root=/dev/vda1 " -- cgit v1.3 From 26a076ed693167dd4d501a880933a75da894a57f Mon Sep 17 00:00:00 2001 From: David Craven Date: Tue, 14 Feb 2017 16:28:32 +0100 Subject: vm: Improve readability of run-vm.sh generation. * gnu/system/vm.scm (common-qemu-options, system-qemu-image/shared-store-script): Improve readability. --- gnu/system/vm.scm | 69 ++++++++++++++++++++++++++++++------------------------- 1 file changed, 38 insertions(+), 31 deletions(-) (limited to 'gnu/system/vm.scm') diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm index a7203d169..103af37c9 100644 --- a/gnu/system/vm.scm +++ b/gnu/system/vm.scm @@ -434,25 +434,26 @@ bootloader refers to: OS kernel, initrd, bootloader data, etc." (define* (common-qemu-options image shared-fs) "Return the a string-value gexp with the common QEMU options to boot IMAGE, with '-virtfs' options for the host file systems listed in SHARED-FS." + (define (virtfs-option fs) - #~(string-append "-virtfs local,path=\"" #$fs - "\",security_model=none,mount_tag=\"" - #$(file-system->mount-tag fs) - "\" ")) + #~(format #f "-virtfs local,path=~s,security_model=none,mount_tag=~s" + #$fs #$(file-system->mount-tag fs))) - #~(string-append - ;; Only enable kvm if we see /dev/kvm exists. + #~(;; Only enable kvm if we see /dev/kvm exists. ;; This allows users without hardware virtualization to still use these ;; commands. - #$(if (file-exists? "/dev/kvm") - " -enable-kvm " - "") - " -no-reboot -net nic,model=virtio \ - " #$@(map virtfs-option shared-fs) " \ - -vga std \ - -drive file=" #$image - ",if=virtio,cache=writeback,werror=report,readonly \ - -m 256")) + #$@(if (file-exists? "/dev/kvm") + '("-enable-kvm") + '()) + + "-no-reboot" + "-net nic,model=virtio" + + #$@(map virtfs-option shared-fs) + "-vga std" + (format #f "-drive file=~a,if=virtio,cache=writeback,werror=report,readonly" + #$image) + "-m 256")) (define* (system-qemu-image/shared-store-script os #:key @@ -479,25 +480,31 @@ it is mostly useful when FULL-BOOT? is true." os #:full-boot? full-boot? #:disk-image-size disk-image-size))) + (define kernel-arguments + #~(list "--root=/dev/vda1" + (string-append "--system=" #$os-drv) + (string-append "--load=" #$os-drv "/boot") + #$@(if graphic? #~() #~("console=ttyS0")) + #+@(operating-system-kernel-arguments os))) + + (define qemu-exec + #~(list (string-append #$qemu "/bin/" #$(qemu-command (%current-system))) + #$@(if full-boot? + #~() + #~("-kernel" #$(operating-system-kernel-file os) + "-initrd" #$(file-append os-drv "/initrd") + (format #f "-append ~s" + (string-join #$kernel-arguments " ")))) + #$@(common-qemu-options image + (map file-system-mapping-source + (cons %store-mapping mappings))))) + (define builder #~(call-with-output-file #$output (lambda (port) - (display - (string-append "#!" #$bash "/bin/sh -exec " #$qemu "/bin/" #$(qemu-command (%current-system)) - -#$@(if full-boot? - #~() - #~(" -kernel " #$(operating-system-kernel-file os) " \ - -initrd " #$os-drv "/initrd \ - -append \"" #$(if graphic? "" "console=ttyS0 ") - "--system=" #$os-drv " --load=" #$os-drv "/boot --root=/dev/vda1 " - (string-join (list #+@(operating-system-kernel-arguments os))) "\" ")) -#$(common-qemu-options image - (map file-system-mapping-source - (cons %store-mapping mappings))) -" \"$@\"\n") - port) + (format port "#!~a~% exec ~a \"$@\"~%" + #$(file-append bash "/bin/sh") + (string-join #$qemu-exec " ")) (chmod port #o555)))) (gexp->derivation "run-vm.sh" builder))) -- cgit v1.3 From 909de139e7f6ab474e6e510a3c15bb4b4731b8cf Mon Sep 17 00:00:00 2001 From: David Craven Date: Tue, 14 Feb 2017 16:28:33 +0100 Subject: vm: Fix full-boot? option. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * gnu/system/vm.scm (virtualized-operating-system): Add full-boot? option. Don't add a %store-mapping when full-boot? is passed. This leads the grub-configuration-file procedure to look for the kernel and initrd in / instead of /gnu/store. Signed-off-by: Ludovic Courtès --- gnu/system/vm.scm | 34 +++++++++++++++++++++------------- 1 file changed, 21 insertions(+), 13 deletions(-) (limited to 'gnu/system/vm.scm') diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm index 103af37c9..5c6e7f684 100644 --- a/gnu/system/vm.scm +++ b/gnu/system/vm.scm @@ -365,7 +365,7 @@ of the GNU system as described by OS." (check? #f) (create-mount-point? #t))))) -(define (virtualized-operating-system os mappings) +(define* (virtualized-operating-system os mappings #:optional (full-boot? #f)) "Return an operating system based on OS suitable for use in a virtualized environment with the store shared with the host. MAPPINGS is a list of to realize in the virtualized OS." @@ -381,6 +381,15 @@ environment with the store shared with the host. MAPPINGS is a list of (string-prefix? "/dev/" source))))) (operating-system-file-systems os))) + (define virtual-file-systems + (cons (file-system + (mount-point "/") + (device "/dev/vda1") + (type "ext4")) + + (append (map mapping->file-system mappings) + user-file-systems))) + (operating-system (inherit os) (initrd (lambda (file-systems . rest) (apply base-initrd file-systems @@ -391,17 +400,16 @@ environment with the store shared with the host. MAPPINGS is a list of ;; Disable swap. (swap-devices '()) - (file-systems (cons* (file-system - (mount-point "/") - (device "/dev/vda1") - (type "ext4")) - - (file-system (inherit - (mapping->file-system %store-mapping)) - (needed-for-boot? #t)) - - (append (map mapping->file-system mappings) - user-file-systems))))) + ;; XXX: When FULL-BOOT? is true, do not add a 9p mount for /gnu/store + ;; since that would lead the bootloader config to look for the kernel and + ;; initrd in it. + (file-systems (if full-boot? + virtual-file-systems + (cons + (file-system + (inherit (mapping->file-system %store-mapping)) + (needed-for-boot? #t)) + virtual-file-systems))))) (define* (system-qemu-image/shared-store os @@ -474,7 +482,7 @@ When FULL-BOOT? is true, the returned script runs everything starting from the bootloader; otherwise it directly starts the operating system kernel. The DISK-IMAGE-SIZE parameter specifies the size in bytes of the root disk image; it is mostly useful when FULL-BOOT? is true." - (mlet* %store-monad ((os -> (virtualized-operating-system os mappings)) + (mlet* %store-monad ((os -> (virtualized-operating-system os mappings full-boot?)) (os-drv (operating-system-derivation os)) (image (system-qemu-image/shared-store os -- cgit v1.3