From d5e197e6ea353e1d635c33b95cd342d51c5baf76 Mon Sep 17 00:00:00 2001
From: rr-
Date: Mon, 22 Aug 2016 01:25:10 +0200
Subject: client/general: add empty href for link buttons

In e464e69 I removed href='#' but I noticed that it broke some things.
Readding href serves two purposes:

- it makes links reachable with Tab key
- it makes links clickable with Enter key

The alternative to this approach was to introduce [tabindex] and [role]
attributes. But not only using tabindex=0 with <a/> is questionable,
it'd require adding a keyboard handler that'd intercept space and return
key presses and simulated link clicks. Since it's best to leave this
kind of thing to the native UI, I went with readding hrefs instead. I
believe that hash hrefs, even though being a common practice, are silly,
so I decided to settle down with empty hrefs.

As a bonus, I added a snippet that prevents middle mouse clicks from
opening such links/buttons in new tabs, which was the motivation for
e464e69.
---
 client/html/posts_page.tpl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'client/html/posts_page.tpl')

diff --git a/client/html/posts_page.tpl b/client/html/posts_page.tpl
index bb4ffe6..7080aa5 100644
--- a/client/html/posts_page.tpl
+++ b/client/html/posts_page.tpl
@@ -36,7 +36,7 @@
                         <% } %>
                     </a>
                     <% if (ctx.parameters && ctx.parameters.tag) { %>
-                        <a data-post-id='<%= post.id %>' class='masstag'>
+                        <a href data-post-id='<%= post.id %>' class='masstag'>
                         </a>
                     <% } %>
                 </li>
-- 
cgit v1.3