diff options
| author | rr- | 2017-02-03 21:20:52 +0100 |
|---|---|---|
| committer | rr- | 2017-02-03 21:20:52 +0100 |
| commit | fd30675124e2ba0fb07fa15af1bec7432cb9f485 (patch) | |
| tree | 7fb76d8b7d7908457627249d27518d5c9ba4beea /server/lint | |
| parent | 894cd295119b33fe786b51558b8b53033813ae27 (diff) | |
server/image-hash: do not depend on image-match
While I hold this library in great esteem for its excellent work on
implementing the original paper, I have several problems with it:
- as of this commit, it (again) has bug fixes unreleased on pip
- its code is badly structured
- forces OOP and then proceeds @staticmethod everything
- bad class design, parameters are repeated in several places
- terrible contract of make_record() and generate_signature()
- ambiguous parameters: path vs. image path vs. image content
- doesn't adhere to PEP-8
- depends on cairo just to render svg images almost no one uses this
library with
Diffstat (limited to 'server/lint')
0 files changed, 0 insertions, 0 deletions